Skip to content

Don't bootstrap on non-bootstrap CI job #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Blaisorblade
Copy link
Contributor

@Blaisorblade Blaisorblade commented Aug 26, 2018

The bootstrap is already done on the other job, and even tho it's not so
expensive, moving the tests there will help balance the job runtime.

On top of #5020.

@Blaisorblade

This comment has been minimized.

@liufengyun
Copy link
Contributor

@Blaisorblade can you rebase to trigger the CI?

@Blaisorblade Blaisorblade self-assigned this Aug 27, 2018
@Blaisorblade Blaisorblade force-pushed the fix-bench-no-bootstrap-on-nonbootstrap branch from 1869436 to 7b2619d Compare August 27, 2018 17:40
@Blaisorblade Blaisorblade removed their assignment Aug 27, 2018
The bootstrap is already done on the other job, and even tho it's not so
expensive, moving the tests there will help balance the job runtime.
@Blaisorblade Blaisorblade force-pushed the fix-bench-no-bootstrap-on-nonbootstrap branch from 7b2619d to 7b27deb Compare August 27, 2018 18:30
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit f22497b into scala:master Aug 28, 2018
@liufengyun liufengyun deleted the fix-bench-no-bootstrap-on-nonbootstrap branch August 28, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants