vscode-dotty: Fix hover functionality with old language server #5162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be easily tested by running in sbt: vscode-dotty/run /path/to/dotty-example-projectand trying to hover over something |
Duhemm
approved these changes
Sep 26, 2018
The current unreleased version of vscode-dotty depends on a new version of vscode-languageclient which parses hover messages in a stricter way, and Dotty Language Server <= 0.9.x sends incorrect hover messages due to a bug in lsp4j. The end result is that when using the current vscode-dotty on a project with an old version of dotty, the hover shows "[object Object]" instead of showing the type and documentation. This commit works around this by manually parsing the hover message when the server version is too old.
smarter
force-pushed
the
fix-vscode-compat
branch
from
603c8fd to
ec8370f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.