Fix #4948: final implicit class can be overridden #5426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
suggested changes
Nov 12, 2018
There was a problem hiding this comment.
Hi @Kobenko. Thanks for the contribution! Can you please add a regression test
|
@allanrenucci yeah. sure. |
|
@allanrenucci hi. can you check my test and tip me how correct to create CLA status? (it is strange, since I already signed it) |
allanrenucci
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
The CLA status sometime doesn't update. CLA is signed.
Two small nitpicks, otherwise LGTM. Can you squash the commits. Thanks!
| @@ -293,7 +293,7 @@ object desugar { | |||
| val impl @ Template(constr0, parents, self, _) = cdef.rhs | |||
| val mods = cdef.mods | |||
| val companionMods = mods | |||
| .withFlags((mods.flags & AccessFlags).toCommonFlags) | |||
| .withFlags((mods.flags & (AccessFlags | Flags.Final)).toCommonFlags) | |||
There was a problem hiding this comment.
Suggested change
| .withFlags((mods.flags & (AccessFlags | Flags.Final)).toCommonFlags) | |
| .withFlags((mods.flags & (AccessFlags | Final)).toCommonFlags) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4948