Add missing types to TASTy reflect #5483
Conversation
| abstract class TypeTreeCoreModule { | ||
|
|
||
| /** Type tree representing an inferred type */ | ||
| type Synthetic <: TypeTree |
There was a problem hiding this comment.
Inferred instead of Synthetic?
There was a problem hiding this comment.
Good idea. I will propose it in another PR.
| type Return = tpd.Return | ||
| type Repeated = tpd.SeqLiteral | ||
| type Inlined = tpd.Inlined | ||
| type SelectOuter = tpd.Select |
There was a problem hiding this comment.
What is SelectOuter? I think maybe there is no need for constructor for Inline
There was a problem hiding this comment.
Select outer is a special case of a Select where it keeps track of the inlined scoped to avoid ambiguities.
Inline is used to keep track of the source file where the tree came from to have a correct position. If the macros would just drop them, every position in the resulting tree would be incorrect.
|
When working on gestalt, I have a hypothesis that macro authors will never need to inspect type trees, because type trees are not semantic -- instead they can always inspect types. If this assumption is true, it can help simplify the reflection API. |
|
That is assuming that we do not care about positions. For example we would not be able to emit an error such as: fooMacro[List[Int]]
^^^ |
No description provided.