Fix file creation in quoted.QuoteCompiler
#5487
Conversation
| @@ -67,7 +67,7 @@ class QuoteCompiler extends Compiler { | |||
| */ | |||
| private def inClass(expr: Expr[_])(implicit ctx: Context): Tree = { | |||
| val pos = Position(0) | |||
| val assocFile = new PlainFile(Path("<quote>")) | |||
| val assocFile = new PlainFile(Path("_quote_")) | |||
There was a problem hiding this comment.
I think the problem is that we're creating a File at all. @nicolasstucki shouldn't this be a VirtualFile ?
There was a problem hiding this comment.
Good point. I forgot to mention the VirtualFile option.
There was a problem hiding this comment.
Yes, a virtual file would be better.
|
@michelou When you create a new branch, you should create it from git checkout origin/master -b new-branchOtherwise you'll drag along all your commits form your current branch. You can salvage the current branch by using an interactive rebase to pick only the commits you want to keep: git rebase -i origin/masterThis open a file with al the commits on this branch but not on master, you can just comment out the lines with the commits you don't want, then save the file. This rewrites the history of the branch. You can then |
michelou
changed the title
quoted.QuoteCompilerquoted.QuoteCompiler
| @@ -67,7 +67,7 @@ class QuoteCompiler extends Compiler { | |||
| */ | |||
| private def inClass(expr: Expr[_])(implicit ctx: Context): Tree = { | |||
| val pos = Position(0) | |||
| val assocFile = new PlainFile(Path("<quote>")) | |||
| val assocFile = new VirtualFile(Path("<quote>").path) | |||
There was a problem hiding this comment.
Why not simply: new VirtualFile("<quote>")
There was a problem hiding this comment.
You're right! Update follows.
|
You still need to sign the Scala CLA |
"<quote>"is not a legal file name on Windows.We suggest to use
"_quote_"instead (similar to path"_site"in doc-tool, seeSite.scala).