-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Cleanup tests #5600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tests #5600
Conversation
allanrenucci
commented
Dec 12, 2018
- Remove std lib blacklist
- Factor out some code
Blocked on #5433 |
f9420b6
to
018ae3d
Compare
Why not wait for 2.13 collections instead? I mean the situation with 2.12 is both acceptable and temporary, so why bother changing it now? I agree that #5433 needs to be addressed. |
I am not sure to understand your comment. This PR is unrelated to #5433. It is a little refactoring in the test infrastructure. It just happen to change the compilation order in some tests which now fail |
ff2fabd
to
788de39
Compare
788de39
to
451bc2b
Compare
- Remove std lib blacklist - Factor out some code
Following fix to scala#4739.
451bc2b
to
affdaf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification! While you're at it, could you try moving the sources in a different package than package scala
? We're only interested in testing that these files still compile and not in actually using them as the real standard library (since we'll switch to 2.13 at some point anyway), therefore using a different package avoids interaction between these files and the symbols the compiler load (in particular, it should allow us to completely get rid of the blacklist).
Can this be done in a separate PR. I probably won't have time to do that in the near future and I don't think it should block this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done in a separate PR. I probably won't have time to do that in the near feature and I don't think it should block this PR
Sure.