Merged
Conversation
This is a partial fix to scala#5831: scala#5831
liufengyun
force-pushed
the
fix-missing-message
branch
from
ac7e574 to
00fbf27
Compare
nicolasstucki
approved these changes
Feb 2, 2019
| def this() = this("") | ||
| def toMessage(implicit ctx: Context): Message = getMessage | ||
| def toMessage(implicit ctx: Context): Message = super.getMessage | ||
| override def getMessage: String = throw new Exception("Use toMessage instead for TypeError") |
Contributor
There was a problem hiding this comment.
This may be annoying but at least no error messages will be empty due to this bug in the future
Contributor
Author
There was a problem hiding this comment.
Indeed, it helped find the problem in Formatting.scala. Thanks for suggesting it 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial fix to #5831 . Once we have #5743, we can add a test case.