-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Inline scala-{library, backend} submodules #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline scala-{library, backend} submodules #5869
Conversation
6271bf0
to
98f2602
Compare
To go further back in history, continue from https://github.com/dotty-staging/scala/tree/1447a7fbbc5dd51a5e561c57bc873576e1ba542c
98f2602
to
f6f1294
Compare
👍 on avoiding submodules most of the time! FWIW, if you ever want git support for moving changes upstream, maybe |
7d8caa7
to
ff15f04
Compare
This PR replaces the scala2-library submodule by copy pasting the relevant source files in tests, and does likewise for the scala-backend subodule by pulling the 16 files we use in compiler/src/scala/tools/nsc/backend/.
After this PR, the submodules will only be used for the community build, which simplifies the build, the setup instructions and hopefully everyone's live when checking out branches. The only downside is that this doesn't preserve the git history of these 16 backend files, one will have to follow the link in the commit message to get access to the full history.