Skip to content

Update to 'given' syntax for inferable parameter #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2019
Merged

Update to 'given' syntax for inferable parameter #5977

merged 1 commit into from
Feb 23, 2019

Conversation

Master-Killer
Copy link
Contributor

Hello.
Pretty sure that the 'with' syntax for inferable parameter is deprecated and has been replaced by the 'given' syntax.

dottybot
dottybot reviewed Feb 23, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@Master-Killer
Copy link
Contributor Author

At the very end, there is also this line:
ConstrApps ::= ConstrApp {‘with’ ConstrApp}

I think this 'with' should also be replaced by 'given', but I am not sure at all.

@odersky
Copy link
Contributor

odersky commented Feb 23, 2019

Thanks for the fixes!

ConstrApps ::= ConstrApp {‘with’ ConstrApp}

No, here the with means mixin, so no given.

@odersky odersky merged commit 40a7d10 into scala:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Master-Killer @odersky @dottybot