Fix #5970: suppress spurious warning in isInstanceOf check#5985
Merged
liufengyun merged 2 commits intoscala:masterfrom Mar 20, 2019
Merged
Fix #5970: suppress spurious warning in isInstanceOf check#5985liufengyun merged 2 commits intoscala:masterfrom
liufengyun merged 2 commits intoscala:masterfrom
Conversation
liufengyun
commented
Feb 25, 2019
| final def mayHaveCommonChild(that: ClassSymbol)(implicit ctx: Context): Boolean = | ||
| !this.is(Final) && !that.is(Final) && (this.is(Trait) || that.is(Trait)) || | ||
| this.derivesFrom(that) || that.derivesFrom(this.symbol) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@OlivierBlanvillain I'm not sure how this fits into your refactoring. Maybe we can delay this PR until the refactoring is merged.
OlivierBlanvillain
approved these changes
Mar 11, 2019
Contributor
OlivierBlanvillain
left a comment
OlivierBlanvillain
left a comment
There was a problem hiding this comment.
I have plans to also factor out the logic in TypeTestsCasts.scala but I didn't do anything so far, so this is LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5970: suppress spurious warning in isInstanceOf check