Skip to content

Add blogpost for 0.13.0-RC1 and 0.12.0 #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 5, 2019
Merged

Add blogpost for 0.13.0-RC1 and 0.12.0 #5992

merged 7 commits into from
Mar 5, 2019

Conversation

biboudis
Copy link
Contributor

@biboudis biboudis commented Feb 27, 2019 •
edited
Loading

  • Add blogpost (main item for review)
  • Add a CHANGELOG.md
  • Rename Eq to Eql a the typeclass derivation to resemble to the new one scala.Eql

@biboudis biboudis added stat:wip itype:meta Issues about process/similar labels Feb 27, 2019
@biboudis biboudis self-assigned this Feb 27, 2019
@biboudis biboudis requested a review from odersky February 27, 2019 17:33
SethTisue
SethTisue reviewed Feb 27, 2019
View reviewed changes
@smarter smarter force-pushed the add-blogpost branch 2 times, most recently from 0660551 to e2f6a86 Compare February 27, 2019 18:33
@biboudis
Copy link
Contributor Author

biboudis commented Feb 28, 2019 •
edited
Loading

The dotty-example-project for mill is blocked (scala/scala3-example-project#26), should I remove the relevant section? Opinions?

@smarter
Copy link
Member

smarter commented Feb 28, 2019

The dotty-example-project for mill is blocked (scala/scala3-example-project#26), should I remove the relevant section? Opinions?

Yes, I probably won't have time to fix mill in the near future.

@biboudis
Copy link
Contributor Author

biboudis commented Mar 1, 2019 •
edited
Loading

Thank you all, I'll merge on Monday in case we receive more comments. Then the word is "out" 🎉

@biboudis biboudis removed the stat:wip label Mar 1, 2019
odersky
odersky approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

LPTK
LPTK reviewed Mar 4, 2019
View reviewed changes
@biboudis biboudis force-pushed the add-blogpost branch 2 times, most recently from ef1fde5 to 6b691a2 Compare March 5, 2019 10:21
@biboudis
Copy link
Contributor Author

biboudis commented Mar 5, 2019

Thank you all for the comments! 🙏

@biboudis biboudis merged commit 0558618 into scala:master Mar 5, 2019
@biboudis biboudis deleted the add-blogpost branch March 5, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter left review comments

@SethTisue SethTisue SethTisue left review comments

@dwijnand dwijnand dwijnand left review comments

@som-snytt som-snytt som-snytt left review comments

@sjrd sjrd sjrd left review comments

@AshishPrasad AshishPrasad AshishPrasad left review comments

@LPTK LPTK LPTK left review comments

@odersky odersky odersky approved these changes

Assignees

@biboudis biboudis

Labels
itype:meta Issues about process/similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@biboudis @smarter @SethTisue @dwijnand @som-snytt @sjrd @odersky @AshishPrasad @LPTK