Flatten term type tree modules #6193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
flatten-term-type-tree-modules
branch
from
440bffb to
171529a
Compare
nicolasstucki
force-pushed
the
flatten-term-type-tree-modules
branch
from
171529a to
d4d3e68
Compare
liufengyun
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
LGTM, expose Terms and Types will definitely improve usability.
I'm a little reserved about that we expose all TypeTrees by default, as from experience they are not that useful, and they tend to cause confusion with types. No need to address in this PR, but keep an eye in the evolution of the API.
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.