Fix #1392: Disallow super-calls that cannot be implemented correctly - #6407
Merged
Conversation
smarter
force-pushed
the
fix-super-intermediate
branch
from
April 30, 2019 16:44
315a670 to
73e33b1
Compare
…ctly A call `super[T].m` that resolves to `A.m` cannot be translated to correct bytecode if `A` is a class (not a trait / interface), but not the direct superclass. Invokespecial would select an overriding method in the direct superclass, rather than `A.m`. We allow this if there are statically no intervening overrides. Based on scala/scala@a980fde and scala/scala@0a84038 Note that unlike Scala 2 we do not need to check if the mixin part of a Super is to a direct parent here because this is already done in TypeAssigner. Co-Authored-By: Jason Zaugg <jzaugg@gmail.com> Co-Authored-By: Lukas Rytz <lukas.rytz@gmail.com>
smarter
force-pushed
the
fix-super-intermediate
branch
from
April 30, 2019 18:24
73e33b1 to
31024d2
Compare
odersky
approved these changes
May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A call
super[T].mthat resolves toA.mcannot be translated tocorrect bytecode if
Ais a class (not a trait / interface), but notthe direct superclass. Invokespecial would select an overriding method
in the direct superclass, rather than
A.m. We allow this if there arestatically no intervening overrides.
Based on
scala/scala@a980fde
and
scala/scala@0a84038
Note that unlike Scala 2 we do not need to check if the mixin part of a
Super is to a direct parent here because this is already done in
TypeAssigner.
Co-Authored-By: Jason Zaugg jzaugg@gmail.com
Co-Authored-By: Lukas Rytz lukas.rytz@gmail.com