Skip to content

Move internal quoted.{Expr,Type} implementations to internal package #6608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 5, 2019

These should not be on the public API.

When I add sealed I had to move them to the same file but I did not realize that I could keep them in the correct package.

@nicolasstucki nicolasstucki requested a review from liufengyun June 5, 2019 12:52
@nicolasstucki nicolasstucki marked this pull request as ready for review June 5, 2019 15:44
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two minor questions (no need to address in this PR):

  • do we need to make an upstream PR to sourcecode?
  • do we want to add private [scala]?

@nicolasstucki
Copy link
Contributor Author

I pushed the commit fixing source code directly, therefore no PR is needed.

private [scala] will not work because we use it from within the dotty package.

@nicolasstucki nicolasstucki merged commit 06c73c1 into scala:master Jun 5, 2019
@nicolasstucki nicolasstucki deleted the move-Expr-implementations-to-internal branch June 5, 2019 18:23
@smarter
Copy link
Member

smarter commented Jun 5, 2019

broke the 2.12 build: http://dotty-ci.epfl.ch/lampepfl/dotty/13353/7

@nicolasstucki
Copy link
Contributor Author

Will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants