Add quote ConstSeq extractor #6651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Jun 9, 2019
| case _ => None | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
This looks like to be a util extractor. Why not have a general SeqLiteral extractor first?
There was a problem hiding this comment.
We do have general SeqLiteral called ExprSeq which is used above. It is true that this is implemented in terms of the other "core" extractors, but it is something that may will use for their first macros.
There was a problem hiding this comment.
Also, this is in scala.quoted.matching which contains all util extractors on Expr, not to be confused with the util in scala.tasty.reflect which would contain extractors on trees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.