Fix span of simple enum cases #6748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The span should start with the enum case itself, not the preceding `case` keyword. This matters is there are many cases in a list.
Even with the fix to enum spans, we could still get a case where a point to a name is missing (maybe because there is a long comment between the start of the definition and the name). The current fix makes the computation succeed more often, but it is not perfect.
nicolasstucki
approved these changes
Jun 26, 2019
smarter
reviewed
Jun 26, 2019
| val nameStart = | ||
| if (point != span.start) point | ||
| else { | ||
| // Point might be too far away from start to be recorded. In this case we fall back to scanning |
There was a problem hiding this comment.
Do we have a test case that exercises this ?
There was a problem hiding this comment.
The original test case was ErrorMessagesID, and I verified that the change here works for it. But c8265f1 fixes the problem by another means, so it's no longer a test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span should start with the enum case itself, not the preceding
casekeyword.This matters if there are many cases in a list.
We got a crash when converting
ErrorMessageIDto Scala since the spans were longer than where anameSpancould be recorded. This led to crash due to a duplicate position when registering a child.