Support erased arguments in splicer #6830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private final def removeEraisedArguments(args: List[Tree], fnTpe: Type): List[Tree] = { | ||
| var result = args | ||
| var index = 0 | ||
| def loop(tp: Type): Unit = tp match { |
There was a problem hiding this comment.
It's not the most beautiful code I've written but it's reasonable in its non erased path and (IMO) pretty clear
There was a problem hiding this comment.
I think we should modify Call to return a List[List[Tree]] for the arguments. It would make this logic much simpler as each element of the outer list corresponds to one of the method types.
There was a problem hiding this comment.
Indeed, it's much simpler! :)
nicolasstucki
suggested changes
Jul 9, 2019
| private final def removeEraisedArguments(args: List[Tree], fnTpe: Type): List[Tree] = { | ||
| var result = args | ||
| var index = 0 | ||
| def loop(tp: Type): Unit = tp match { |
There was a problem hiding this comment.
I think we should modify Call to return a List[List[Tree]] for the arguments. It would make this logic much simpler as each element of the outer list corresponds to one of the method types.
OlivierBlanvillain
force-pushed
the
support-erased-arguments-in-splicer
branch
from
d27d402 to
9a431dc
Compare
nicolasstucki
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.