Re-contextualize Liftable.toExpr #6924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefine `Liftable.toExpr` as `def toExpr(x: T): given QuoteContext => Expr[T]`. This change makes it simpler to implement `Liftable` as the return type can be omitted.
nicolasstucki
force-pushed
the
recontextualize-liftable-toexpr
branch
from
ddc12dd to
2425707
Compare
anatoliykmetyuk
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine
Liftable.toExprasdef toExpr(x: T): given QuoteContext => Expr[T].This change makes it simpler to implement
Liftableas the return type can be omitted.Extracted from #6881 where this change aligns with the new quotes internal representation.