Type constant annotation arguments correctly #8655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
An annotation argument of type boolean, byte, char or short will be represented as a CONSTANT_Integer in the classfile, so back in 3b882c2 I made sure that we took this type into account when creating a `Constant`, but this is not enough: we store parsed constants in a `values` cache, and the same constant might be used with different expected types, so the conversion needs to be done on demand.
odersky
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An annotation argument of type boolean, byte, char or short will be
represented as a CONSTANT_Integer in the classfile, so back in
3b882c2 I made sure that we took this
type into account when creating a
Constant, but this is not enough: westore parsed constants in a
valuescache, and the same constant mightbe used with different expected types, so the conversion needs to be
done on demand.