Let inline val implement abstract inline def/val #8832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
let-inline-vals-implement-abstract-inline-def-or-val
branch
2 times, most recently
from
84e061f to
a799cd9
Compare
nicolasstucki
force-pushed
the
let-inline-vals-implement-abstract-inline-def-or-val
branch
from
a799cd9 to
ee24482
Compare
liufengyun
approved these changes
Apr 30, 2020
|
|
||
| class C1 extends C: | ||
| inline val x = 1 | ||
| inline val y = 2 |
There was a problem hiding this comment.
A side note: in inline val, we require the rhs to be a literal type, which is not really related to inline. Meanwhile, const-folding can be achieved by annotating the constant type explicitly.
There was a problem hiding this comment.
Actually, inline val requires a literal type result type and a pure body. This is a consequence of being marked as inline, as these are the only values that can be soundly inlined. We use constant folding to inline it because thee type already provides this functionality.
There was a problem hiding this comment.
It's more about semantics than soundness. There is an inconsistency between inline vals and inline parameters.
nicolasstucki
deleted the
let-inline-vals-implement-abstract-inline-def-or-val
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.