Remove incorrect type simplification#9019
Merged
smarter merged 1 commit intoscala:masterfrom May 21, 2020
Merged
Conversation
`TypeOps#simplify` is supposed to produce a type `=:=` the original type, but it replaced type variables created using `newTypeVar` by one of their bound, this is wrong since that type variable might get instantiated to a different type later. This simplification was added in scala#2209 to prevent a pickling crash in tests/pos/i2152.scala but does not appear to be needed anymore: an uninstantiated type variable being preserved after typer is always wrong, so the underlying bug must have been fixed since then.
Contributor
|
test performance please |
Contributor
|
let's just check that this has no performance implications. Otherwise LGTM |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9019/ to see the changes. Benchmarks is based on merging with master (38272aa) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeOps#simplifyis supposed to produce a type=:=the originaltype, but it replaced type variables created using
newTypeVarby oneof their bound, this is wrong since that type variable might get
instantiated to a different type later. This simplification was added
in #2209 to prevent a pickling crash in tests/pos/i2152.scala but does
not appear to be needed anymore: an uninstantiated type variable being
preserved after typer is always wrong, so the underlying bug must have
been fixed since then.