Avoid infinite loop in type variable instantiation #9030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9030/ to see the changes. Benchmarks is based on merging with master (59587ba) |
Rename `checkNonCyclic` to `occursAtToplevel` and refactor it to return a boolean, use it in `ConstraintHandling#instanceType` to make sure we do not introduce a cycle when instantiating a type variable. Some alternatives I considered: - Run `widenInferred` inside frozen constraints: this prevents `Set[A] | Set[Int]` to be widened to `Set[Int]` after instantiating `A := Int` - Run `widenInferred` with the upper bound of `param` instead of `param` itself as a bound: I think this is still not safe because the upper bound of `param` might recursively refer to `param`, it also breaks type inference of one expression in ZIO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
checkNonCyclictooccursAtTopleveland refactor it to returna boolean, use it in
ConstraintHandling#instanceTypeto make sure wedo not introduce a cycle when instantiating a type variable.
Some alternatives I considered:
widenInferredinside frozen constraints: this preventsSet[A] | Set[Int]to be widened toSet[Int]after instantiatingA := IntwidenInferredwith the upper bound ofparaminstead ofparamitself as a bound: I think this is still not safe because the upper
bound of
parammight recursively refer toparam, it also breakstype inference of one expression in ZIO.