Skip to content

Replace deprecated package #9082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2020

Conversation

yu-croco
Copy link
Contributor

According to Scala Standard Library, JavaConverters has deprecated since Scala version 2.13.0, so I replaced it.
Also, I imported only the needed resources, instead of all of it.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@yu-croco yu-croco requested a review from dottybot May 30, 2020 02:02
@yu-croco
Copy link
Contributor Author

yu-croco commented May 30, 2020

I signed the CLA from Scala Individual Contributor License Agreement - CLA after I created this PR.

Please let me know if I misunderstand about it. 🙇

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @yu-croco 🎉

@liufengyun liufengyun merged commit aff000e into scala:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants