Fix #9342: Use semantic name for inline bindings #9379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#9342
branch
2 times, most recently
from
a1bd4e8 to
771c1ca
Compare
odersky
reviewed
Jul 27, 2020
| @@ -295,7 +295,7 @@ object NameKinds { | |||
| val DocArtifactName: UniqueNameKind = new UniqueNameKind("$doc") | |||
| val UniqueInlineName: UniqueNameKind = new UniqueNameKind("$i") | |||
| val InlineScrutineeName: UniqueNameKind = new UniqueNameKind("$scrutinee") | |||
| val InlineBinderName: UniqueNameKind = new UniqueNameKind("$elem") | |||
| val InlineBinderName: UniqueNameKind = new UniqueNameKind("$bind") | |||
There was a problem hiding this comment.
I find bind too unspecific, and of the wrong kind. If we use it, it should be binder, not bind. But maybe proxy is better?
There was a problem hiding this comment.
Indeed, renamed to proxy
odersky
approved these changes
Aug 10, 2020
nicolasstucki
force-pushed
the
fix-#9342
branch
from
affad53 to
8aabfac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.