Remove unnecessary evals, escape extra params #9526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you publish artifacts somewhere, and test with https://github.com/lampepfl/packtest on different platforms? |
|
Do you know if there's some simple script that I can run to publish the artifacts? |
|
@abgruszecki You can use |
liufengyun
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
LGTM
It's tested in lampepfl/packtest#22 that the change is OK on Linux and OSX.
The windows CI has a problem, but the changes look reasonable and should not affect windows.
|
@abgruszecki You need to declare yourself to CLA :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found the source(s) of the escaping problems.
I think I also found out why the
eval execis needed: to split JAVA_OPTS into separate arguments.