Fix #9492: Avoid forcing nested annotation #9536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java allows annotations inside arrays inside annotations, when parsing the outer annotation, we need to produce an untyped tree for the array and therefore the nested annotations. Previously this was done using `Annotation#tree` which actually produces a typed tree, this works since typed trees can be used as untyped tree but it requires forcing the content of the nested annotation which can lead to cycles. Instead, we now use a dedicated subclass of Annotation with an extra `untpdTree` method we use for the purpose of generating a tree for the nested annotation without forcing anything.
smarter
force-pushed
the
fix-annot-cycle
branch
from
5095033 to
abe1314
Compare
odersky
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java allows annotations inside arrays inside annotations, when parsing
the outer annotation, we need to produce an untyped tree for the array
and therefore the nested annotations. Previously this was done using
Annotation#treewhich actually produces a typed tree, this works sincetyped trees can be used as untyped tree but it requires forcing the
content of the nested annotation which can lead to cycles.
Instead, we now use a dedicated subclass of Annotation with an extra
untpdTreemethod we use for the purpose of generating a tree for thenested annotation without forcing anything.