Fix #9346: Add fallback on lazy ref cycles #9546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findMember of RefinedTypes had a fallback to safe_& in the case of cyclic references. It also needs to handle the case where a LazyRef depends on itself during evaluation. This fixes scala#9346 for normal compiles. Unpickling needs another fix in Variances.scala.
It turns out that now that we know that cyclic evaluations of LazyRefs can happen in normal code, we can just use a CyclicReference for them. There's no need to label this case with a different exception.
|
Unfortunately with this change akka-streams goes into an infinite loop, here's the stacktrace which involves interspersed nested calls to recoverable_& and LazyRef#ref: https://gist.github.com/smarter/fbed5375cc79f3f5688d05ad4378c6c4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findMember of RefinedTypes had a fallback to safe_& in the case of cyclic references.
It also needs to handle the case where a LazyRef depends on itself during evaluation.
This fixes #9346 for normal compiles. Unpickling needs another fix in Variances.scala.