Move quoted null and unit encoding to internal #9551
Conversation
These are opimizations for `'{}`/`'{()}` and `'{null}` which should not be used directly
nicolasstucki
force-pushed
the
move-quoted-null-and-unit-encoding-to-internal
branch
from
518c51a to
566bdf5
Compare
| def Unit: QuoteContext ?=> quoted.Expr[Unit] = qctx ?=> { | ||
| import qctx.tasty._ | ||
| Literal(Constant(())).seal.asInstanceOf[quoted.Expr[Unit]] | ||
| } |
There was a problem hiding this comment.
It seems both can be val instead of def?
There was a problem hiding this comment.
They could but they would not get the optimization where the context parameter is passed directly as one of the method parameters and the closure is not created. We effectively call the following method at runtime (not closure creation needed):
def Unit(using q: QuoteContext): quoted.Expr[Unit] = {
import qctx.tasty._
Literal(Constant(())).seal.asInstanceOf[quoted.Expr[Unit]]
}There was a problem hiding this comment.
Good point, maybe we can write it directly, instead of the original form?
There was a problem hiding this comment.
It is like this to align with the quote internal encoding to simplify the transformation.
There was a problem hiding this comment.
I will consider changing the encoding but this is a larger change that will take some time to accomplish.
There was a problem hiding this comment.
Thanks for the clarification, it makes sense.
nicolasstucki
deleted the
move-quoted-null-and-unit-encoding-to-internal
branch
No description provided.