Skip to content

Move all macro related classes to dotty.tools.dotc.quoted.[reflect] #9625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Aug 24, 2020

Classes have been added to different locations for historical reasons. Currently, there is no reason to have them separated and it makes it slightly harder to navigate. Also renamed dotty.tools.dotc.quoted.QuoteContext to QuoteContextImpl to distinguish it from scala.quoted.QuoteContext.

@nicolasstucki nicolasstucki marked this pull request as ready for review August 24, 2020 09:01
@nicolasstucki nicolasstucki marked this pull request as draft August 24, 2020 12:22
@nicolasstucki nicolasstucki force-pushed the cleanup-dotty.tools.dotc.quoted branch 5 times, most recently from 034d558 to 5aee950 Compare August 24, 2020 15:37
@nicolasstucki nicolasstucki marked this pull request as ready for review August 24, 2020 18:13
@nicolasstucki nicolasstucki force-pushed the cleanup-dotty.tools.dotc.quoted branch 3 times, most recently from b1462dd to 6e27f43 Compare August 26, 2020 10:08
@nicolasstucki nicolasstucki force-pushed the cleanup-dotty.tools.dotc.quoted branch from 6e27f43 to 795dd8b Compare August 26, 2020 11:21
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 725e0c8 into scala:master Aug 26, 2020
@nicolasstucki nicolasstucki deleted the cleanup-dotty.tools.dotc.quoted branch August 26, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants