Skip to content

Rename Reflection tasty to reflect #9961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 7, 2020

Rename to give an intuitive name to access the AST based API and try to avoid confusion with the TASTy file format.
Keep tasty as a deprecated alias of reflect.

@nicolasstucki

This comment has been minimized.

@nicolasstucki nicolasstucki force-pushed the rename-reflect-tasty-to-ast branch from 8271f2e to aec9be6 Compare October 7, 2020 12:18
@nicolasstucki nicolasstucki self-assigned this Oct 7, 2020
@nicolasstucki nicolasstucki force-pushed the rename-reflect-tasty-to-ast branch 2 times, most recently from 958151b to 5954b29 Compare October 7, 2020 15:46
@nicolasstucki nicolasstucki marked this pull request as ready for review October 7, 2020 19:24
@nicolasstucki nicolasstucki force-pushed the rename-reflect-tasty-to-ast branch from 5954b29 to 0f229f0 Compare October 7, 2020 21:07
@nicolasstucki nicolasstucki changed the title Rename Reflection tasty to ast Rename Reflection tasty to reflect Oct 7, 2020
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Rename to give an intuitive name to access the AST based API and try to avoid confusion with the TASTy file format.
Keep `tasty` as a deprecated alias of `reflect`.
@nicolasstucki nicolasstucki force-pushed the rename-reflect-tasty-to-ast branch from 0f229f0 to 01a1dcf Compare October 8, 2020 09:53
@nicolasstucki nicolasstucki merged commit c900cde into scala:master Oct 12, 2020
@nicolasstucki nicolasstucki deleted the rename-reflect-tasty-to-ast branch October 12, 2020 08:31
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants