Skip to content

Commit 911d995

Browse files
authored
Make sharing_token usage more explicit, don’t pass context token as query param (#1400)
* Make sharing_token usage more explicit, never pass context token as query param * update cassettes for group 1 * update all snapshots * format * re-add old parameters as deprecated * changelog * new cassettes
1 parent e48d490 commit 911d995

File tree

56 files changed

+2407
-2533
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+2407
-2533
lines changed

webknossos/Changelog.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@ For upgrade instructions, please check the respective _Breaking Changes_ section
1919
### Changed
2020
- The interactive prompt asking for the WEBKNOSSOS user token was removed. Specify your token as parameter or environment variable to ensure authenticated requests to WEBKNOSSOS server. [#1391](https://github.com/scalableminds/webknossos-libs/pull/1391)
2121
- Updated pylibCZIrw package to 5.1.1, which does not require custom-built wheels anymore. [#1394](https://github.com/scalableminds/webknossos-libs/pull/1394)
22+
- In the methods `Dataset.trigger_dataset_import`, `Dataset.trigger_reload_in_datastore` and `RemoteDataset.trigger_reload_in_datastore` the parameter `token` was deprecated (use an authenticated webknossos context instead). In `RemoteDataset.download_mesh` and `RemoteSegmentationLayer.download_mesh` the parameter `token` was renamed to `sharing_token` to clarify that it is meant for a dataset sharing token. Otherwise, use an authenticated webknossos context instead. [#1400](https://github.com/scalableminds/webknossos-libs/pull/1400)
2223

2324
### Fixed
24-
25+
- Fixed a bug where user tokens would sometimes show up in the logging as a GET parameter. [#1400](https://github.com/scalableminds/webknossos-libs/pull/1400)
2526

2627
## [3.0.3](https://github.com/scalableminds/webknossos-libs/releases/tag/v3.0.3) - 2025-11-11
2728
[Commits](https://github.com/scalableminds/webknossos-libs/compare/v3.0.2...v3.0.3)

webknossos/tests/cassettes/test_annotation/test_annotation_upload_download_roundtrip.yml

Lines changed: 48 additions & 49 deletions
Large diffs are not rendered by default.

webknossos/tests/cassettes/test_annotation/test_bounding_box_roundtrip.yml

Lines changed: 46 additions & 48 deletions
Large diffs are not rendered by default.

webknossos/tests/cassettes/test_annotation/test_dataset_access_via_annotation.yml

Lines changed: 45 additions & 47 deletions
Large diffs are not rendered by default.

webknossos/tests/cassettes/test_annotation/test_edited_volume_annotation_upload_download.yml

Lines changed: 8 additions & 8 deletions
Large diffs are not rendered by default.

webknossos/tests/cassettes/test_annotation/test_remote_annotation_list.yml

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

webknossos/tests/cassettes/test_api_client/test_annotation_info.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ http_interactions:
22
- request:
33
method: GET
44
path: >-
5-
/api/v12/annotations/570ba0092a7c0e980056fe9b/info?timestamp=1762780927000
5+
/api/v12/annotations/570ba0092a7c0e980056fe9b/info?timestamp=1764166584000
66
headers:
77
host: localhost:9000
88
accept: '*/*'
@@ -22,7 +22,7 @@ http_interactions:
2222
cache-control: no-cache
2323
referrer-policy: origin-when-cross-origin, strict-origin-when-cross-origin
2424
x-permitted-cross-domain-policies: master-only
25-
date: Mon, 10 Nov 2025 13:22:06 GMT
25+
date: Wed, 26 Nov 2025 14:16:23 GMT
2626
content-type: application/json
2727
content-length: '1911'
2828
body:

webknossos/tests/cassettes/test_api_client/test_build_info.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ http_interactions:
2222
access-control-max-age: '600'
2323
access-control-allow-origin: '*'
2424
x-permitted-cross-domain-policies: master-only
25-
date: Mon, 10 Nov 2025 13:22:07 GMT
25+
date: Wed, 26 Nov 2025 14:16:24 GMT
2626
content-type: application/json
2727
content-length: '400'
2828
body:
2929
encoding: utf8
3030
data: >-
31-
{"webknossos":{"name":"webknossos","ciTag":"","commitHash":"12861dd0fb559bce276735a35ea2efd09a7d9b30","ciBuild":"19229113534","scalaVersion":"2.13.16","version":"19229113534","sbtVersion":"1.11.7","commitDate":"Mon
32-
Nov 10 11:51:14 2025
33-
+0100"},"schemaVersion":144,"httpApiVersioning":{"currentApiVersion":12,"oldestSupportedApiVersion":5},"localDataStoreEnabled":true,"localTracingStoreEnabled":true}
31+
{"webknossos":{"name":"webknossos","ciTag":"","commitHash":"1b4f2402e8bc2a3a9e7e1584b1e5dc9b3bb0813c","ciBuild":"19701880048","scalaVersion":"2.13.16","version":"19701880048","sbtVersion":"1.11.7","commitDate":"Wed
32+
Nov 26 11:17:21 2025
33+
+0000"},"schemaVersion":145,"httpApiVersioning":{"currentApiVersion":12,"oldestSupportedApiVersion":5},"localDataStoreEnabled":true,"localTracingStoreEnabled":true}
3434
compression: none

webknossos/tests/cassettes/test_api_client/test_current_user_info_and_user_logged_time.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ http_interactions:
2121
cache-control: no-cache
2222
referrer-policy: origin-when-cross-origin, strict-origin-when-cross-origin
2323
x-permitted-cross-domain-policies: master-only
24-
date: Mon, 10 Nov 2025 13:22:07 GMT
24+
date: Wed, 26 Nov 2025 14:16:24 GMT
2525
content-type: application/json
2626
content-length: '717'
2727
body:
@@ -51,7 +51,7 @@ http_interactions:
5151
cache-control: no-cache
5252
referrer-policy: origin-when-cross-origin, strict-origin-when-cross-origin
5353
x-permitted-cross-domain-policies: master-only
54-
date: Mon, 10 Nov 2025 13:22:07 GMT
54+
date: Wed, 26 Nov 2025 14:16:24 GMT
5555
content-type: application/json
5656
content-length: '692'
5757
body:

webknossos/tests/cassettes/test_api_client/test_dataset_info.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ http_interactions:
2121
cache-control: no-cache
2222
referrer-policy: origin-when-cross-origin, strict-origin-when-cross-origin
2323
x-permitted-cross-domain-policies: master-only
24-
date: Mon, 10 Nov 2025 13:22:07 GMT
24+
date: Wed, 26 Nov 2025 14:16:24 GMT
2525
content-type: application/json
2626
content-length: '112'
2727
body:
@@ -51,13 +51,13 @@ http_interactions:
5151
cache-control: no-cache
5252
referrer-policy: origin-when-cross-origin, strict-origin-when-cross-origin
5353
x-permitted-cross-domain-policies: master-only
54-
date: Mon, 10 Nov 2025 13:22:07 GMT
54+
date: Wed, 26 Nov 2025 14:16:24 GMT
5555
content-type: application/json
56-
content-length: '2632'
56+
content-length: '2163'
5757
body:
5858
encoding: utf8
5959
data: >-
60-
{"id":"59e9cfbdba632ac2ab8b23b5","name":"l4_sample","dataSource":{"id":{"name":"l4_sample","team":"Organization_X"},"dataLayers":[{"name":"color","elementClass":"uint8","category":"color","dataFormat":"wkw","resolutions":[[1,1,1],[2,2,1],[4,4,1],[8,8,2],[16,16,4]],"mags":[{"mag":[1,1,1],"path":"/webknossos/binaryData/Organization_X/l4_sample/color/1"},{"mag":[2,2,1],"path":"/webknossos/binaryData/Organization_X/l4_sample/color/2-2-1"},{"mag":[4,4,1],"path":"/webknossos/binaryData/Organization_X/l4_sample/color/4-4-1"},{"mag":[8,8,2],"path":"/webknossos/binaryData/Organization_X/l4_sample/color/8-8-2"},{"mag":[16,16,4],"path":"/webknossos/binaryData/Organization_X/l4_sample/color/16-16-4"}],"defaultViewConfiguration":{"color":[255,0,0]},"numChannels":1,"boundingBox":{"topLeft":[3072,3072,512],"width":1024,"height":1024,"depth":1024}},{"largestSegmentId":2504697,"name":"segmentation","elementClass":"uint32","category":"segmentation","dataFormat":"wkw","resolutions":[[1,1,1],[2,2,1],[4,4,1],[8,8,2],[16,16,4]],"mags":[{"mag":[1,1,1],"path":"/webknossos/binaryData/Organization_X/l4_sample/segmentation/1"},{"mag":[2,2,1],"path":"/webknossos/binaryData/Organization_X/l4_sample/segmentation/2-2-1"},{"mag":[4,4,1],"path":"/webknossos/binaryData/Organization_X/l4_sample/segmentation/4-4-1"},{"mag":[8,8,2],"path":"/webknossos/binaryData/Organization_X/l4_sample/segmentation/8-8-2"},{"mag":[16,16,4],"path":"/webknossos/binaryData/Organization_X/l4_sample/segmentation/16-16-4"}],"numChannels":1,"boundingBox":{"topLeft":[3072,3072,512],"width":1024,"height":1024,"depth":1024}}],"scale":{"factor":[11.239999771118164,11.239999771118164,28],"unit":"nanometer"}},"dataStore":{"name":"localhost","url":"http://localhost:9000","allowsUpload":true,"jobsSupportedByAvailableWorkers":[],"jobsEnabled":false},"owningOrganization":"Organization_X","allowedTeams":[{"id":"570b9f4b2a7c0e3b008da6ec","name":"team_X1","organization":"Organization_X","isOrganizationTeam":true}],"allowedTeamsCumulative":[{"id":"570b9f4b2a7c0e3b008da6ec","name":"team_X1","organization":"Organization_X","isOrganizationTeam":true}],"isActive":true,"isPublic":true,"description":"This
60+
{"id":"59e9cfbdba632ac2ab8b23b5","name":"l4_sample","dataSource":{"id":{"name":"l4_sample","team":"Organization_X"},"dataLayers":[{"name":"color","elementClass":"uint8","category":"color","dataFormat":"wkw","resolutions":[[1,1,1],[2,2,1],[4,4,1],[8,8,2],[16,16,4]],"mags":[{"mag":[1,1,1],"path":"./color/1"},{"mag":[2,2,1],"path":"./color/2-2-1"},{"mag":[4,4,1],"path":"./color/4-4-1"},{"mag":[8,8,2],"path":"./color/8-8-2"},{"mag":[16,16,4],"path":"./color/16-16-4"}],"defaultViewConfiguration":{"color":[255,0,0]},"numChannels":1,"boundingBox":{"topLeft":[3072,3072,512],"width":1024,"height":1024,"depth":1024}},{"largestSegmentId":2504697,"name":"segmentation","elementClass":"uint32","category":"segmentation","dataFormat":"wkw","resolutions":[[1,1,1],[2,2,1],[4,4,1],[8,8,2],[16,16,4]],"mags":[{"mag":[1,1,1],"path":"./segmentation/1"},{"mag":[2,2,1],"path":"./segmentation/2-2-1"},{"mag":[4,4,1],"path":"./segmentation/4-4-1"},{"mag":[8,8,2],"path":"./segmentation/8-8-2"},{"mag":[16,16,4],"path":"./segmentation/16-16-4"}],"numChannels":1,"boundingBox":{"topLeft":[3072,3072,512],"width":1024,"height":1024,"depth":1024}}],"scale":{"factor":[11.239999771118164,11.239999771118164,28],"unit":"nanometer"}},"dataStore":{"name":"localhost","url":"http://localhost:9000","allowsUpload":true,"jobsSupportedByAvailableWorkers":[],"jobsEnabled":false},"owningOrganization":"Organization_X","allowedTeams":[{"id":"570b9f4b2a7c0e3b008da6ec","name":"team_X1","organization":"Organization_X","isOrganizationTeam":true}],"allowedTeamsCumulative":[{"id":"570b9f4b2a7c0e3b008da6ec","name":"team_X1","organization":"Organization_X","isOrganizationTeam":true}],"isActive":true,"isPublic":true,"description":"This
6161
is a test
62-
description","directoryName":"l4_sample","created":1508495293789,"isEditable":true,"lastUsedByUser":1762780927961,"logoUrl":"/assets/images/mpi-logos.svg","sortingKey":1508495293789,"metadata":[{"key":"key","type":"string","value":"value"},{"key":"number","type":"number","value":42},{"key":"list","type":"string[]","value":["a","b","c"]}],"isUnreported":false,"tags":[],"folderId":"570b9f4e4bb848d0885ea917","usedStorageBytes":1692207513,"isVirtual":false}
62+
description","directoryName":"l4_sample","created":1508495293789,"isEditable":true,"lastUsedByUser":1764166585040,"logoUrl":"/assets/images/mpi-logos.svg","sortingKey":1508495293789,"metadata":[{"key":"key","type":"string","value":"value"},{"key":"number","type":"number","value":42},{"key":"list","type":"string[]","value":["a","b","c"]}],"isUnreported":false,"tags":[],"folderId":"570b9f4e4bb848d0885ea917","usedStorageBytes":0,"isVirtual":false}
6363
compression: none

0 commit comments

Comments
 (0)