Make sharing_token usage more explicit, don’t pass context token as query param #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
commented
Nov 26, 2025
|
|
||
| assert remote_ds.name == "test_remote_metadata" | ||
|
|
||
| # allow 10s for wk to scan the used storage bytes |
Member
Author
There was a problem hiding this comment.
the server’s finishUpload call now blocks until the storage is measured.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
normanrz
approved these changes
Nov 26, 2025
|
|
||
| assert remote_ds.name == "test_remote_metadata" | ||
|
|
||
| # allow 10s for wk to scan the used storage bytes |
Member
|
Not sure it is necessary to update all the snapshots. I usually only remove the ones that are affected and then run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
sharing_tokens may occasionally be used as context tokens to access shared datasets, never should normal user tokens be passed as sharing_tokens. One problem this may cause is the token showing up in logging.Dataset.trigger_dataset_import,Dataset.trigger_reload_in_datastoreandRemoteDataset.trigger_reload_in_datastorethe parametertokenwas deprecated (use an authenticated webknossos context instead). InRemoteDataset.download_meshandRemoteSegmentationLayer.download_meshthe parametertokenwas renamed tosharing_tokento clarify that it is meant for a dataset sharing token. Otherwise, use an authenticated webknossos context instead.Issues:
Todos: