Replace vcr-py for tests #1198
Merged
Replace vcr-py for tests #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanrz
reviewed
Nov 22, 2024
Member
normanrz
left a comment
normanrz
left a comment
There was a problem hiding this comment.
Looks already pretty good. Maybe you can comment on the state of the commented-out code. I think some of that could be revived in a follow-up.
| "https://webknossos.org/links/93zLg9U9vJ3c_UWp", | ||
| "http://localhost:9000/datasets/Organization_X/l4_sample", | ||
| "http://localhost:9000/datasets/Organization_X/l4_sample/view", | ||
| # "http://localhost:9000/datasets/Organization_X/l4_sample_dev_sharing/view?token=ilDXmfQa2G8e719vb1U9YQ#%7B%22orthogonal%7D", |
Member
There was a problem hiding this comment.
Would be good to also test sharing links and short links. Can be a followup.
…-tests' of github.com:scalableminds/webknossos-libs into introduce-proxay-for-tests
2 tasks
normanrz
approved these changes
Nov 29, 2024
Member
normanrz
left a comment
normanrz
left a comment
There was a problem hiding this comment.
Great. Let's get this merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Todos:
Make sure to delete unnecessary points or to check all before merging:
Fixing tests: