-
Notifications
You must be signed in to change notification settings - Fork 14
Fix add existing tree to annotation #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| def __eq__(self, other: Any) -> bool: | ||
| return type(other) is type(self) and self._id == other._id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this class inherits from group which also defines __eq__, right? couldn't the method here be omitted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think I tested it before, but it didn't work. I just figured that @attr.define adds a standard __eq__ implementation. This can be avoided when adding @attr.define(eq=False). Thanks for mentioning it, I removed the __eq__ and the __hash__ method from the Skeleton class.
philippotto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thank you!
Description:
Issues:
Todos:
Make sure to delete unnecessary points or to check all before merging: