Skip to content

fail, when tests do not run through, and fix failing tests #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
valentin-pinkau merged 8 commits into from
Nov 11, 2025
Merged

fail, when tests do not run through, and fix failing tests #1392

valentin-pinkau merged 8 commits into from
Nov 11, 2025

Conversation

@valentin-pinkau
Copy link
Member

@valentin-pinkau valentin-pinkau commented Nov 10, 2025 •
edited
Loading

Description:

  • This PR fixes the test.py to actually fail if the unit tests fail
  • Fixes various tests and bugs that were introduced since the test.py was used.

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog

@valentin-pinkau valentin-pinkau self-assigned this Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10162 8537 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
webknossos/webknossos/dataset/layer/segmentation_layer/attachments/attachment.py 92% 🟢
webknossos/webknossos/dataset/layer/segmentation_layer/attachments/attachments.py 86% 🟢
TOTAL 89% 🟢

updated for commit: 0f8c973 by action🐍

@valentin-pinkau valentin-pinkau requested a review from fm3 November 11, 2025 10:04
@fm3 fm3 mentioned this pull request Nov 11, 2025
Open
fm3
fm3 approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this through! Please add a changelog entry, then this should be good to go.

@valentin-pinkau valentin-pinkau enabled auto-merge (squash) November 11, 2025 10:40
@valentin-pinkau valentin-pinkau merged commit 0ea9d5e into master Nov 11, 2025
23 checks passed
@valentin-pinkau valentin-pinkau deleted the fix_ci_tests branch November 11, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@valentin-pinkau valentin-pinkau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valentin-pinkau @fm3