the shrinker will warn on provided indirect targets if they are used …

[natansil]

…in compilation

@ittaiz @or-shachar

[natansil]

@nadavwe

[jvican]

@natansil? Is there any reason why you closed this?

[natansil]

@jvican , this PR was done by mistake. We altered the plugin quite a lot in order to make it useful for building with bazel.
You can take a look at this PR for the rules_scala repo. we put the plugin code in a separate 'third_party' directory with a BSD-3 license file...

[jvican]

Okay, please keep me in the loop with that. The Center is always interested to know where our work is reused 😄.

I don't quite get the changes that you proposed here. But is there something that we can merge upstream so that the rest of the users of this plugin benefit? Or are your changes Bazel-specific?

[natansil]

the changes are quite bazel-specific in the sense that they make the plugin expect to get bazel targets labels in order to notify the users which target labels they need to add to direct dependencies

[ittaiz]

They are generic in the sense that Pants could benefit from it too since they have similar concepts but since the plugin and the build tool needs to agree on the format of the inputs I'm not sure it's that practical.

…

On Sun, 16 Jul 2017 at 12:30 Natan Silnitsky ***@***.***> wrote: the changes are quite bazel-specific in the sense that they make the plugin expect to get bazel targets labels in order to notify the users which target labels they need to add to direct dependencies — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIFylodTYU0BYm6l4wH4uWvS5qnhmPks5sOdhJgaJpZM4OH-t4> .