Skip to content

ScalafmtSbtReporter: mention scalafmt in messages#176

Merged
kitbellew merged 1 commit intoscalameta:masterfrom
kitbellew:138
Dec 2, 2021
Merged

ScalafmtSbtReporter: mention scalafmt in messages#176
kitbellew merged 1 commit intoscalameta:masterfrom
kitbellew:138

Conversation

@kitbellew
Copy link
Copy Markdown
Contributor

Fixes #138.

@kitbellew kitbellew requested a review from poslegm November 30, 2021 19:45
Copy link
Copy Markdown
Collaborator

@poslegm poslegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that more clear way is creating own logger

class SbtScalafmtLogger {
  def info(message: String): Unit = log.info(s"scalafmt: $message")
  // ....
}

but for such a small amount of code this may be overkill

@kitbellew
Copy link
Copy Markdown
Contributor Author

I think that more clear way is creating own logger

class SbtScalafmtLogger {
  def info(message: String): Unit = log.info(s"scalafmt: $message")
  // ....
}

but for such a small amount of code this may be overkill

actually, it's a good idea! let me change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error messages from scalafmt should clearly be marked as such to not be confused with compiler error messages

2 participants