Update readme.md with badge and JDK compatibility#341
Update readme.md with badge and JDK compatibility#341kitbellew merged 2 commits intoscalameta:mainfrom
Conversation
joriscode
commented
Jan 9, 2025
joriscode
commented
- Update the badge because it was outdated (referencing 2.4.6).
- Add JDK compatibility to indicate drop of Java 8 support.
kitbellew
left a comment
kitbellew
left a comment
There was a problem hiding this comment.
thank you for the submission. a couple of questions.
| libraryDependencies += "org.scalameta" % "sbt-scalafmt_2.12_1.0" % PLUGIN_VERSION | ||
| ``` | ||
|
|
||
| #### JDK compatibility |
There was a problem hiding this comment.
should it be under installation? this file doesn't have any other #### headings, everything is ###.
There was a problem hiding this comment.
Yes, that was my goal (to have this as a sub-section of installation section). If you prefer it to be a "h3" section, I will happily change this.
| [](https://gitter.im/scalameta/scalafmt?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | ||
| [](https://discordapp.com/channels/632642981228314653/632665341864181780) | ||
| [](https://search.maven.org/artifact/org.scalameta/sbt-scalafmt/) | ||
| [](https://index.scala-lang.org/scalameta/sbt-scalafmt) |
There was a problem hiding this comment.
could you also revise the "maven central" reference below? (i found one on line 12)
There was a problem hiding this comment.
Done!
I pushed a new commit because I didn't want to force-push. Let me know your preferences if you have any.
|
@joriscode thank you, merged, please delete your branch |
|
Thank you for accepting my changes! |
| #### JDK compatibility | ||
| | JDK | Release | | ||
| | ---- | ---------------| | ||
| | 8 | Up to `v2.5.1` | |
There was a problem hiding this comment.
Nitpick: 2.5.2 was still compatible with JDK8
3 participants
