sbt: upgrade dependency to v1.12.9/v2.0.0-RC11#436
Merged
kitbellew merged 2 commits intoscalameta:mainfrom Apr 10, 2026
Merged
Conversation
That version fixes ability to download scala-library at given version, rather than the scala version of the build. See sbt/sbt#9028 (2.x) and coursier/sbt-coursier#609 (1.x).
kitbellew
changed the title
tgodzik
reviewed
Apr 9, 2026
tgodzik
approved these changes
Apr 10, 2026
Contributor
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
just one suggestion otherwise LGTM
| if (mintags.isEmpty) curtags.nonEmpty | ||
| else curtags.isEmpty || cmp(mintags, curtags) > 0 | ||
| } | ||
| if (bad) sys.error(s"sbt-scalafmt requires sbt $v+ [current=$sbtVersion") |
Contributor
There was a problem hiding this comment.
MAybe warning would be enough? But that's up to you
Contributor
Author
There was a problem hiding this comment.
if the version is older, download will fall with likely cryptic explanation. they might not see the warning just above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That version fixes ability to download scala-library at given version, rather than the scala version of the build.
See sbt/sbt#9028 (2.x) and coursier/sbt-coursier#609 (1.x). Helps with #433.