Fix the integration test and workflow for Object Storage adapter

[KodaiD]

Description

This PR fixes the integration test and workflow for S3 and Cloud Storage adapter.

Since S3 and Cloud Storage have a strict request rate limit, integration tests for those adapters fail, currently. To address this issue, this PR fixes the test workflow to execute those tests in separate buckets.

Additionally, since Cloud Storage has a stricter request rate limit allowing one write per second, this PR introduces some waits for some write-heavy spots.

The test is verified in https://github.com/scalar-labs/scalardb/actions/runs/19738491550.

Related issues and/or PRs

• Add support for S3 #3141
• Add support for Cloud Storage #3179

Changes made

• Updated the GitHub Actions workflow file to execute test groups in separate buckets.
• Updated some Consensus Commit-related test cases, which trigger many writes, to include waits.

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[KodaiD]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces fixes for integration tests on S3 and Cloud Storage by working around their rate limits. The changes involve adding waits in write-heavy tests and modifying the test workflow. The approach is sound, but there are opportunities to improve maintainability by reducing code duplication and eliminating magic numbers. I've also identified a potential issue where a thread-limiting override was removed, which might reintroduce the very rate-limiting problems this PR aims to solve.

[Copilot]

Pull request overview

This PR addresses integration test failures for S3 and Cloud Storage adapters caused by strict request rate limits. The solution splits tests into separate buckets per test group and adds rate-limiting waits for Cloud Storage's strict 1-write-per-second limit.

Key changes:

• Expanded the GitHub Actions workflow matrix from 2 test modes to 14 distinct test groups, each using a separate S3/Cloud Storage bucket to avoid rate limit conflicts
• Added Cloud Storage-specific sleeps (1 second per write operation, 2 seconds in setUp/tearDown) to handle the strict rate limits
• Made visibility changes to the base test class to enable subclass customization for Cloud Storage

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
.github/workflows/object-storage-adapter-check.yaml	Reorganized test execution into 14 distinct test groups, each using separate buckets with descriptive suffixes; updated S3 region and bucket naming
ConsensusCommitSpecificIntegrationTestBase.java	Changed visibility of fields (recoveryExecutor, groupCommitter) and methods (setUp, truncateTables) from private to protected to support subclass overrides
ConsensusCommitSpecificIntegrationTestWithObjectStorage.java	Added Cloud Storage-specific sleeps in setUp/tearDown methods and duplicated cleanup logic from parent
ConsensusCommitIntegrationTestWithObjectStorage.java	Added Cloud Storage-specific sleeps in setUp/tearDown methods
SingleCrudOperationTransactionIntegrationTestWithObjectStorage.java	Overrode populateRecords() to add 1-second sleeps between writes for Cloud Storage rate limiting
ObjectStorageSinglePartitionKeyIntegrationTest.java	Added getColumnWithMaxValue() override to use 'Z' characters instead of 0xFF for Cloud Storage TEXT max values
ObjectStorageSingleClusteringKeyScanIntegrationTest.java	Added getColumnWithMaxValue() override to use 'Z' characters instead of 0xFF for Cloud Storage TEXT max values
ObjectStorageMultiplePartitionKeyIntegrationTest.java	Added getColumnWithMaxValue() override to use 'Z' characters instead of 0xFF for Cloud Storage TEXT max values
ObjectStorageMultipleClusteringKeyScanIntegrationTest.java	Added getColumnWithMaxValue() override to use 'Z' characters instead of 0xFF for Cloud Storage TEXT max values
ObjectStorageConditionalMutationIntegrationTest.java	Removed custom thread count override (reverted to base class default)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[komamitsu]

LGTM! 👍

[Torch3333]

LGTM, thank you!

[brfrn169]

LGTM! Thank you!

[feeblefakie]

LGTM! Thank you!