Add configuration option to enable/disable active transaction management

[brfrn169]

Description

This PR adds scalar.db.active_transaction_management.enabled configuration option to enable/disable the active transaction management. The default value is true for backward compatibility.

Related issues and/or PRs

N/A

Changes made

• Added scalar.db.active_transaction_management.enabled configuration option to enable/disable the active transaction management (default: true).
• Introduced AbstractDistributedTransactionProvider as a base class to consolidate wrapper logic for transaction managers.
• Refactored ConsensusCommitProvider and JdbcTransactionProvider to extend the new abstract class.
• Refactored ActiveTransactionManagedDistributedTransactionManager and
  ActiveTransactionManagedTwoPhaseCommitTransactionManager.
  • Extracted common logic from both classes into ActiveTransactionRegistry
    and SynchronizedScanner.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Added scalar.db.active_transaction_management.enabled configuration option to enable/disable the active transaction management (default: true).

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option to explicitly enable or disable active transaction management, ensuring backward compatibility by setting the default to true. It also refactors the transaction provider architecture by introducing an abstract base class, AbstractDistributedTransactionProvider, to consolidate the wrapping logic for distributed and two-phase commit transaction managers. This change streamlines the implementation of concrete transaction providers like ConsensusCommitProvider and JdbcTransactionProvider, making the system more modular and maintainable.

Highlights

• New Configuration Option: Added scalar.db.active_transaction_management.enabled to allow explicit control over active transaction management, with a default value of true for backward compatibility.
• Architectural Refactoring: Introduced AbstractDistributedTransactionProvider as a new abstract base class to centralize and consolidate the wrapper logic for distributed and two-phase commit transaction managers.
• Provider Simplification: Refactored ConsensusCommitProvider and JdbcTransactionProvider to extend the new AbstractDistributedTransactionProvider, simplifying their implementations by delegating common wrapping logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a configuration option to enable or disable active transaction management and refactors transaction provider implementations into a new abstract base class, AbstractDistributedTransactionProvider. The changes are well-structured, and the new configuration option is properly integrated and tested. The refactoring successfully centralizes the transaction manager decoration logic. I have one suggestion to address a potential issue in the new abstract class where a state management wrapper appears to be missing for two-phase commit transactions.

[Copilot]

Pull request overview

This PR adds a new configuration option scalar.db.active_transaction_management.enabled to control whether active transaction management is applied to transaction managers, with a default value of true for backward compatibility. The PR also refactors the transaction provider architecture by introducing AbstractDistributedTransactionProvider as a base class to consolidate the wrapper logic.

Key Changes:

• Added scalar.db.active_transaction_management.enabled configuration property with default value true
• Introduced AbstractDistributedTransactionProvider base class to centralize transaction manager wrapping logic
• Refactored ConsensusCommitProvider and JdbcTransactionProvider to extend the new abstract class and implement createRaw* methods

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
core/src/main/java/com/scalar/db/config/DatabaseConfig.java	Added configuration property and getter for enabling/disabling active transaction management
core/src/main/java/com/scalar/db/api/AbstractDistributedTransactionProvider.java	New abstract base class that conditionally applies state management and active transaction management wrappers based on configuration
core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitProvider.java	Refactored to extend AbstractDistributedTransactionProvider and implement raw transaction manager creation methods
core/src/main/java/com/scalar/db/transaction/jdbc/JdbcTransactionProvider.java	Refactored to extend AbstractDistributedTransactionProvider and implement raw transaction manager creation methods
core/src/test/java/com/scalar/db/config/DatabaseConfigTest.java	Added assertions to verify the new configuration property defaults to true and can be set to false

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[brfrn169]

/gemini review

[gemini-code-assist]

Code Review

This is a great pull request that significantly improves the codebase. The introduction of AbstractDistributedTransactionProvider effectively reduces code duplication. The extraction of logic into ActiveTransactionRegistry and SynchronizedScanner makes the transaction management classes cleaner and more focused. The new configuration option to disable active transaction management is also a valuable addition. I have a couple of suggestions for further improvement.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Torch3333]

LGTM, thank you!

[feeblefakie]

LGTM! Thank you!

[komamitsu]

LGTM! 👍