feat: support DS records #12
Conversation
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
| __API_VERSION__ = 'v2beta1' | ||
|
|
||
|
|
||
| class ScalewayDSAlgorithm(Enum): |
There was a problem hiding this comment.
I'm missing some dnssec algorithms (4, 9, 11) https://www.iana.org/assignments/dns-sec-alg-numbers/dns-sec-alg-numbers.xhtml
Does the documentation is incorrect or it's just unsupported as it's reserved now ?
https://www.scaleway.com/en/developers/api/domains-and-dns/registrar-api/#path-domains-update-domain-dnssec
| } | ||
| values.append(value) | ||
| # The TTL is hardcoded and is not returned by the API | ||
| return {'type': _type, 'values': values, 'ttl': '3600'} |
There was a problem hiding this comment.
We can't set the TTL for the DS record, and the API doesn't return the TTL. Based on my tests, I assume it is always set to 3600.
Signed-off-by: Ludovic Ortega <[email protected]>
|
|
||
| class ScalewayProvider(BaseProvider): | ||
| SUPPORTS_GEO = False | ||
| SUPPORTS_DYNAMIC = True | ||
| SUPPORTS_ROOT_NS = True |
There was a problem hiding this comment.
I've added support for root NS
https://github.com/octodns/octodns/blob/main/octodns/source/base.py#L9
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
|
Hello @jerjako, |
M0NsTeRRR
force-pushed
the
main
branch
2 times, most recently
from
10a4908 to
802e37f
Compare
Signed-off-by: Ludovic Ortega <[email protected]>
Signed-off-by: Ludovic Ortega <[email protected]>
|
@remyleone I've fixed the CI if you can run the workflow as it works on my fork https://github.com/M0NsTeRRR/octodns-scaleway/actions/runs/15449413829 |
Fix #11
Few things to note :
https://github.com/scaleway/octodns-scaleway/blob/main/octodns_scaleway/__init__.py#L172