Skip to content

fix(lb): remove required option on Create loadbalancer subscriber #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix(lb): remove required option on Create loadbalancer subscriber #3296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cmd/scw/testdata/test-all-usage-lb-subscriber-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ USAGE:
scw lb subscriber create [arg=value ...]

ARGS:
name Subscriber name
email-config.email Email address to send alerts to
webhook-config.uri URI to receive POST requests
[project-id] Project ID to use. If none is passed the default project ID will be used
[organization-id] Organization ID to use. If none is passed the default organization ID will be used
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)
name Subscriber name
[email-config.email] Email address to send alerts to
[webhook-config.uri] URI to receive POST requests
[project-id] Project ID to use. If none is passed the default project ID will be used
[organization-id] Organization ID to use. If none is passed the default organization ID will be used
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)

FLAGS:
-h, --help help for create
Expand Down
10 changes: 5 additions & 5 deletions cmd/scw/testdata/test-all-usage-lb-subscriber-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ USAGE:
scw lb subscriber update <subscriber-id ...> [arg=value ...]

ARGS:
subscriber-id Subscriber ID
name Subscriber name
email-config.email Email address to send alerts to
webhook-config.uri URI to receive POST requests
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)
subscriber-id Subscriber ID
name Subscriber name
[email-config.email] Email address to send alerts to
[webhook-config.uri] URI to receive POST requests
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)

FLAGS:
-h, --help help for update
Expand Down
8 changes: 4 additions & 4 deletions docs/commands/lb.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,8 +1303,8 @@ scw lb subscriber create [arg=value ...]
| Name | | Description |
|------|---|-------------|
| name | Required | Subscriber name |
| email-config.email | Required | Email address to send alerts to |
| webhook-config.uri | Required | URI to receive POST requests |
| email-config.email | | Email address to send alerts to |
| webhook-config.uri | | URI to receive POST requests |
| project-id | | Project ID to use. If none is passed the default project ID will be used |
| organization-id | | Organization ID to use. If none is passed the default organization ID will be used |
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |
Expand Down Expand Up @@ -1432,8 +1432,8 @@ scw lb subscriber update <subscriber-id ...> [arg=value ...]
|------|---|-------------|
| subscriber-id | Required | Subscriber ID |
| name | Required | Subscriber name |
| email-config.email | Required | Email address to send alerts to |
| webhook-config.uri | Required | URI to receive POST requests |
| email-config.email | | Email address to send alerts to |
| webhook-config.uri | | URI to receive POST requests |
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |


Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/moby/buildkit v0.11.6
github.com/opencontainers/go-digest v1.0.0
github.com/pkg/errors v0.9.1
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230717114303-9b6e07d6384b
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230720143451-785dc161c15d
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.7.0
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncj
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230717114303-9b6e07d6384b h1:b5kG1Uzb4Fst6BoLXsgowQHj6WOkECIj+UkM1YwTIQY=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230717114303-9b6e07d6384b/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230720143451-785dc161c15d h1:fMaLlUJQWVFQeQTMPi5AFXPyM/MZgyFdSo4tp5BOShg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230720143451-785dc161c15d/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
Expand Down
8 changes: 4 additions & 4 deletions internal/namespaces/lb/v1/lb_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2908,14 +2908,14 @@ func lbSubscriberCreate() *core.Command {
{
Name: "email-config.email",
Short: `Email address to send alerts to`,
Required: true,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "webhook-config.uri",
Short: `URI to receive POST requests`,
Required: true,
Required: false,
Deprecated: false,
Positional: false,
},
Expand Down Expand Up @@ -3052,14 +3052,14 @@ func lbSubscriberUpdate() *core.Command {
{
Name: "email-config.email",
Short: `Email address to send alerts to`,
Required: true,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "webhook-config.uri",
Short: `URI to receive POST requests`,
Required: true,
Required: false,
Deprecated: false,
Positional: false,
},
Expand Down