Skip to content

feat(instance): add support detach and attach filesystem #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2025

Conversation

Laure-di
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Laure-di Laure-di requested review from remyleone and a team as code owners June 11, 2025 07:48
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Jun 11, 2025
@Laure-di Laure-di changed the title feat(file): disable beta flag feat(instance): add support detach and attach filesystem Jun 11, 2025
@Laure-di Laure-di force-pushed the fix-diable-beta-file branch 13 times, most recently from 4ac1aba to 1417152 Compare June 11, 2025 11:34
@Laure-di Laure-di force-pushed the fix-diable-beta-file branch from e452ff3 to fd59446 Compare June 12, 2025 09:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.65%. Comparing base (5bf53e0) to head (e4e88e4).
Report is 674 commits behind head on master.

Files with missing lines Patch % Lines
commands/commands.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (e4e88e4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (e4e88e4)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4797       +/-   ##
===========================================
- Coverage   75.45%   54.65%   -20.80%     
===========================================
  Files         202      316      +114     
  Lines       44323    80842    +36519     
===========================================
+ Hits        33444    44185    +10741     
- Misses       9653    35251    +25598     
- Partials     1226     1406      +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laure-di Laure-di force-pushed the fix-diable-beta-file branch from 421de5e to 14e2363 Compare June 12, 2025 11:28
@remyleone remyleone enabled auto-merge June 12, 2025 11:49
@remyleone remyleone added this pull request to the merge queue Jun 12, 2025
Merged via the queue into scaleway:master with commit 0b301e3 Jun 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants