feat(tooltip): improve tooltip behavior and fix some issues #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthprost
force-pushed
the
feat/tooltip-improvements
branch
from
2bdb459 to
7ef7be2
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #2209 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 153 153
Lines 3429 3429
Branches 472 472
=======================================
Hits 3283 3283
Misses 99 99
Partials 47 47 Continue to review full report at Codecov.
|
ModuloM
approved these changes
Jan 19, 2023
QuiiBz
suggested changes
Jan 19, 2023
ModuloM
reviewed
Jan 19, 2023
philibea
reviewed
Jan 23, 2023
| if (timer.current) { | ||
| setReverseAnimation(false) | ||
| clearTimeout(timer.current) | ||
| timer.current = undefined |
There was a problem hiding this comment.
can you add a test unit on this line ?
QuiiBz
approved these changes
Jan 23, 2023
matthprost
force-pushed
the
feat/tooltip-improvements
branch
from
1e1b7c8 to
98ab3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
There was multiple issues with tooltip I fixed them and improved the opening / closing behavior:
The following changes where made:
Screen.Recording.2023-01-19.at.16.08.04.mov