Skip to content

Add language override feature#349

Open
L1Q wants to merge 1 commit intoschmich:masterfrom
L1Q:master
Open

Add language override feature#349
L1Q wants to merge 1 commit intoschmich:masterfrom
L1Q:master

Conversation

@L1Q
Copy link
Contributor

@L1Q L1Q commented Oct 12, 2020

Hopefully resolves #228

  • refactor Messages.js
  • expose refreshLang for easy translations reloading
  • update settings version with new setting
  • update settings page with new option
  • make all pages refresh language before rendering

No need to reload extension!
P.S.: hacktoberfest tag or label much appreciated

- refactor Messages.js
- expose refreshLang for easy translations reloading
- update settings version with new setting
- update settings page with new option
- make all pages refresh language before rendering
@schmich
Copy link
Owner

schmich commented Oct 13, 2020

Awesome, this looks promising.

One issue: Messages.js is actually dynamically generated from messages.json (see Makefile and this script). My fault for not putting a banner at the top of Messages.js saying that it was generated by a tool. In general, I'd like to not have to maintain message IDs in multiple places.

Hacktoberfest label applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow user to explicitly choose extension language

2 participants