resume timer after the computer wake up from sleep mode#400
Draft
cytim wants to merge 2 commits intoschmich:masterfrom
Draft
resume timer after the computer wake up from sleep mode#400cytim wants to merge 2 commits intoschmich:masterfrom
cytim wants to merge 2 commits intoschmich:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
(Attempt to fix #296 and the related issues.)
When the computer sleeps, the timer's
tickIntervalandexpireTimeoutwill be paused by the system. When the system wakes up, the timer is resumed without acknowledging the paused period. This appears to the users that the timer is frozen.Todo
ticketIntervalandexpireTimeoutwith a singlecountdownInterval.countdownIntervalruns every second to comparecheckpointStartAtto track the time - the timer can tick/expire correctly as soon as the script resumes from sleep mode.Experiment
The computer slept after
tick 3at around 09:20:58. When the computer resumed at around 09:26:06,tick 4happened immediately and updatednextTickAtto the correct time. Finally, the timer expired at 09:27:59 as expected.