Update import for Generator and Callable types#34
Merged
lagru merged 3 commits intoscientific-python:mainfrom May 14, 2025
Merged
Update import for Generator and Callable types#34lagru merged 3 commits intoscientific-python:mainfrom
lagru merged 3 commits intoscientific-python:mainfrom
Conversation
476d82c to
c145367
Compare
Member
|
Good catch! I'm curious how you stumbled on these? Perhaps I'm missing a linter that should have caught these. E.g. I guess at the very least mypy should have complained in the CI? 🤔 Anyway, I'm very happy reviewing PRs as they come. Thank you. 😊 |
Contributor
Author
|
Manual inspection. I was curious about how the yield section had been processed and in the stubs I saw Sequence, Iterable and some other input types were imported from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of these types have been deprecated from typing to the ones in collections.abc.
If you want to leave this open a bit I can add more if there were as I notice them while I try the
library, otherwise I can do other PRs, whatever makes your life easier.