Convert to generic platform wheel #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses errors like the following: ERROR: pytest-fixture-config 1.4.0 has requirement pytest<4.0.0, but you'll have pytest 4.5.0 which is incompatible. ERROR: pytest-shutil 1.6.0 has requirement pytest<4.0.0, but you'll have pytest 4.5.0 which is incompatible. ERROR: pytest-virtualenv 1.6.0 has requirement pytest<4.0.0, but you'll have pytest 4.5.0 which is incompatible.
---- Adapted from scikit-build/cmake-python-distributions@2a7966cc15b travis: Fix execution of test from source tree setting skbuild platname Since building the project specifying --plat-name or CMAKE_OSX_* variables leads to different SKBUILD_DIR (e.g "_skbuild/macosx-10.6-x86_64-3.6" vs "_skbuild/macosx-10.11-x86_64-3.6" , the code below attempt to guess the most likely plat-name, extracting the plat-name from the first sub-directory found under "_skbuild" directory. ---- Adapted from scikit-build/cmake-python-distributions@52e1da0b48 ix test_cmake_module on macOS requiring scikit-build >= 0.10.0 ---- Adapted from scikit-build/cmake-python-distributions@dffd84a63a scikit-build >= 0.9.0 converted skbuild.constants into functions to support custom platform name. See scikit-build/scikit-build@cb324b8
Adapted from scikit-build/cmake-python-distributions@9bc10f963 Since scikit-build 0.10.0 more carefully tests availability of Visual Studio generator, this commit fixes the issue using Visual Studio 2017 image for python 3.6 and python 3.7
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 86.95% 86.66% -0.29%
==========================================
Files 1 1
Lines 23 30 +7
Branches 3 5 +2
==========================================
+ Hits 20 26 +6
- Partials 3 4 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 86.95% 86.66% -0.29%
==========================================
Files 1 1
Lines 23 30 +7
Branches 3 5 +2
==========================================
+ Hits 20 26 +6
- Partials 3 4 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.