Skip to content

Support building on Alpine Linux. See #22 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2019

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented May 30, 2019

Co-authored-by: Ondřej Čertík [email protected]

@jcfr jcfr force-pushed the support-building-on-alpine branch from 77a7287 to c75f17d Compare May 30, 2019 23:02
@jcfr jcfr mentioned this pull request May 30, 2019
@jcfr jcfr force-pushed the support-building-on-alpine branch from c75f17d to 9f3737c Compare May 30, 2019 23:07
@jcfr jcfr force-pushed the support-building-on-alpine branch from 9f3737c to bdf4762 Compare May 30, 2019 23:10
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #25 into master will decrease coverage by 13.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
- Coverage   86.66%   73.33%   -13.34%     
===========================================
  Files           1        1               
  Lines          30       30               
  Branches        5        5               
===========================================
- Hits           26       22        -4     
- Misses          0        4        +4     
  Partials        4        4
Impacted Files Coverage Δ
ninja/__init__.py 73.33% <0%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c5ce4...bdf4762. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files           1        1           
  Lines          30       30           
  Branches        5        5           
=======================================
  Hits           26       26           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c5ce4...bdf4762. Read the comment docs.

@certik
Copy link
Contributor

certik commented May 30, 2019

I am a little bit worried if the -D_BSD_SOURCE flag does not break it for non-Alpine linux builds?

@jcfr
Copy link
Contributor Author

jcfr commented May 30, 2019

-D_BSD_SOURCE flag does not break it for non-Alpine linux builds?

Good point, I suggest we address the issue when it comes.

@jcfr jcfr merged commit a92f57c into scikit-build:master May 30, 2019
@jcfr jcfr deleted the support-building-on-alpine branch May 30, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants